Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20055] Fix compilation of Fast DDS Python tests #4158

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Dec 18, 2023

Description

#4131 broke the compilation of Fast DDS Python tests. It seems on that project we have a problem when Fast DDS marks a method with FASTDDS_TODO_BEFORE an exported method with RTPS_DllAPI. This change must be included in:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.13.0 milestone Dec 18, 2023
@EduPonz EduPonz added the skip-ci Automatically pass CI label Dec 18, 2023
@EduPonz
Copy link
Author

EduPonz commented Dec 18, 2023

I've cancelled CI as this cannot break anything

@EduPonz EduPonz merged commit cb876d6 into master Dec 18, 2023
3 of 11 checks passed
@EduPonz EduPonz deleted the hotfix/fastdds_python_tests_compilation branch December 18, 2023 11:11
EduPonz added a commit that referenced this pull request Dec 18, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Dec 20, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants