[20021] TCP support for Discovery server CLI and env. var. #4097

cferreiragonz · 2023-12-04T14:51:35Z

Description

This PR adds TCPv4/6 support for both the Fast DDS CLI and the ROS_DISCOVERY_SERVER environment variable.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Related tests: [20021] Add TCP env. var. and CLI support to Discovery Server Tests Discovery-Server#66 (PR)
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [20021] TCP support for Discovery server CLI and env var and example Fast-DDS-docs#599 (PR)
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

src/cpp/rtps/RTPSDomain.cpp

tools/fds/server.cpp

tools/fds/server.h

tools/fds/server.cpp

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.cpp

test/blackbox/common/BlackboxTestsDiscovery.cpp

cferreiragonz · 2023-12-11T13:44:29Z

@richiprosima please test this

cferreiragonz · 2023-12-11T15:38:38Z

@richiprosima please test this

cferreiragonz · 2023-12-12T07:08:10Z

@richiprosima please test this

cferreiragonz · 2023-12-12T10:04:27Z

@Mergifyio rebase

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

mergify · 2023-12-12T10:04:50Z

rebase

✅ Branch has been successfully rebased

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2023-12-12T15:29:11Z

@richiprosima please test this

cferreiragonz · 2023-12-13T06:52:16Z

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

mergify · 2023-12-13T06:52:17Z

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

#4132 [20021] TCP support for Discovery server CLI and env. var. (backport #4097) has been created for branch 2.12.x but encountered conflicts
#4133 [20021] TCP support for Discovery server CLI and env. var. (backport #4097) has been created for branch 2.11.x but encountered conflicts
#4134 [20021] TCP support for Discovery server CLI and env. var. (backport #4097) has been created for branch 2.10.x but encountered conflicts
#4135 [20021] TCP support for Discovery server CLI and env. var. (backport #4097) has been created for branch 2.6.x but encountered conflicts

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2023-12-13T11:08:16Z

@richiprosima please test this

* Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # versions.md

* Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServer_main.cpp # examples/cpp/dds/DiscoveryServerExample/README.md # examples/cpp/dds/DiscoveryServerExample/arg_configuration.h # examples/cpp/dds/DiscoveryServerExample/common.h # versions.md

* Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationPublisher.cpp # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationSubscriber.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServer_main.cpp # examples/cpp/dds/DiscoveryServerExample/README.md # examples/cpp/dds/DiscoveryServerExample/arg_configuration.h # examples/cpp/dds/DiscoveryServerExample/common.h # include/fastdds/rtps/attributes/ServerAttributes.h # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp # test/blackbox/common/BlackboxTestsDiscovery.cpp # tools/fds/server.cpp # tools/fds/server.h # versions.md

* TCP support for Discovery server CLI and env var (#4097) * Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServer_main.cpp # examples/cpp/dds/DiscoveryServerExample/README.md # examples/cpp/dds/DiscoveryServerExample/arg_configuration.h # examples/cpp/dds/DiscoveryServerExample/common.h # versions.md * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* TCP support for Discovery server CLI and env var (#4097) * Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # versions.md * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* TCP support for Discovery server CLI and env var (#4097) * Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationPublisher.cpp # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationSubscriber.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServer_main.cpp # examples/cpp/dds/DiscoveryServerExample/README.md # examples/cpp/dds/DiscoveryServerExample/arg_configuration.h # examples/cpp/dds/DiscoveryServerExample/common.h # include/fastdds/rtps/attributes/ServerAttributes.h # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp # test/blackbox/common/BlackboxTestsDiscovery.cpp # tools/fds/server.cpp # tools/fds/server.h # versions.md * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Revert "Fix Conflicts" This reverts commit b79bbe9. * Fix building incompatibilities Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Remove Discovery Server example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply changes & Fix env var reading Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Fix CLI tool Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* TCP support for Discovery server CLI and env var (#4097) * Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2653efb) # Conflicts: # versions.md * Fix Conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

This was referenced Dec 4, 2023

[20021] TCP support for Discovery server CLI and env var and example eProsima/Fast-DDS-docs#599

Merged

[20021] Add TCP env. var. and CLI support to Discovery Server Tests eProsima/Discovery-Server#66

Merged

elianalf suggested changes Dec 5, 2023

View reviewed changes

elianalf suggested changes Dec 7, 2023

View reviewed changes

EduPonz added this to the v2.13.0 milestone Dec 8, 2023

cferreiragonz force-pushed the feature/tcp_disc_server branch from fea8bbf to dee169f Compare December 11, 2023 13:51

cferreiragonz added needs rebase ci-pending PR which CI is running labels Dec 12, 2023

cferreiragonz added 11 commits December 12, 2023 10:04

Refs #20021: TCP support for CLI Discovery server

40ed152

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Add TCP to Discovery Server Example

48ac223

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: CLI: Add argument for TCP port and example

24877df

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Add TCP support to environment variable

63b12b4

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Use autofill feature & check existing transports

eb0e26e

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support

2389a47

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Apply Revision's Suggestions

d4e45d8

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Add test for TCP single IP address & Fix DNS test

54b6c6a

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Add default TCP interface to CLI

605e1e5

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Uncrustify

eb1d7dc

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #20021: Update tests with new locator syntax & fix CLI

f426538

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz force-pushed the feature/tcp_disc_server branch from dc87231 to f426538 Compare December 12, 2023 10:04

Refs #20021: Update Readme

a5abc93

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

elianalf previously approved these changes Dec 12, 2023

View reviewed changes

cferreiragonz removed the needs rebase label Dec 12, 2023

Refs #20021: Fix warnings

201f5fa

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz dismissed elianalf’s stale review via 201f5fa December 13, 2023 07:14

Refs 20021: Update versions.md

7f947e4

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

elianalf approved these changes Dec 14, 2023

View reviewed changes

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Dec 14, 2023

EduPonz merged commit 2653efb into master Dec 14, 2023
12 of 14 checks passed

EduPonz deleted the feature/tcp_disc_server branch December 14, 2023 07:37

mergify bot mentioned this pull request Dec 14, 2023

[20021] TCP support for Discovery server CLI and env. var. (backport #4097) #4132

Merged

mergify bot mentioned this pull request Dec 14, 2023

[20021] TCP support for Discovery server CLI and env. var. (backport #4097) #4133

Merged

mergify bot mentioned this pull request Dec 14, 2023

[20021] TCP support for Discovery server CLI and env. var. (backport #4097) #4134

Merged

mergify bot mentioned this pull request Dec 14, 2023

[20021] TCP support for Discovery server CLI and env. var. (backport #4097) #4135

Merged

jepemi mentioned this pull request Dec 15, 2023

Rename locators from failing tests eProsima/Fast-DDS-statistics-backend#218

Merged

jepemi mentioned this pull request Dec 18, 2023

Add logical port setting to tests eProsima/Fast-DDS-statistics-backend#219

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20021] TCP support for Discovery server CLI and env. var. #4097

[20021] TCP support for Discovery server CLI and env. var. #4097

cferreiragonz commented Dec 4, 2023 •

edited by elianalf

Loading

cferreiragonz commented Dec 11, 2023

cferreiragonz commented Dec 11, 2023

cferreiragonz commented Dec 12, 2023

cferreiragonz commented Dec 12, 2023

mergify bot commented Dec 12, 2023

cferreiragonz commented Dec 12, 2023

cferreiragonz commented Dec 13, 2023

mergify bot commented Dec 13, 2023 •

edited

Loading

cferreiragonz commented Dec 13, 2023

[20021] TCP support for Discovery server CLI and env. var. #4097

[20021] TCP support for Discovery server CLI and env. var. #4097

Conversation

cferreiragonz commented Dec 4, 2023 • edited by elianalf Loading

Description

Contributor Checklist

Reviewer Checklist

cferreiragonz commented Dec 11, 2023

cferreiragonz commented Dec 11, 2023

cferreiragonz commented Dec 12, 2023

cferreiragonz commented Dec 12, 2023

mergify bot commented Dec 12, 2023

✅ Branch has been successfully rebased

cferreiragonz commented Dec 12, 2023

cferreiragonz commented Dec 13, 2023

mergify bot commented Dec 13, 2023 • edited Loading

✅ Backports have been created

cferreiragonz commented Dec 13, 2023

cferreiragonz commented Dec 4, 2023 •

edited by elianalf

Loading

mergify bot commented Dec 13, 2023 •

edited

Loading