Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IgnoreNonExistentSegment test (backport #4036) #4057

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Improve IgnoreNonExistentSegment test (backport #4036) #4057

merged 2 commits into from
Dec 5, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 27, 2023 •
edited by elianalf
Loading

Description

This is a backport of #4036 along with #4052 into 2.12.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Improve IgnoreNonExistentSegment test (#4036)
fbee189 
* Refs #19887. Platform specific behavior on IgnoreNonExistentSegment test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19887. Use `num_threads` in loop.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Fix warning in Mac rewarding unnecessary lambda capture (#4052)
8eae255 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.12.2 milestone Nov 27, 2023
@MiguelCompany MiguelCompany changed the title Improve IgnoreNonExistentSegment test Improve IgnoreNonExistentSegment test (backport #4036) Nov 27, 2023
@MiguelCompany MiguelCompany mentioned this pull request Nov 29, 2023
Closed
@elianalf
Copy link
Contributor

elianalf commented Dec 4, 2023

@richiprosima please test mac

@elianalf
Copy link
Contributor

elianalf commented Dec 4, 2023

@richiprosima please test linux

@elianalf
Copy link
Contributor

elianalf commented Dec 5, 2023

@richiprosima please test mac

1 similar comment
@EduPonz
Copy link

EduPonz commented Dec 5, 2023

@richiprosima please test mac

@EduPonz
Copy link

EduPonz commented Dec 5, 2023

@richiprosima please test mac

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Dec 5, 2023
@MiguelCompany MiguelCompany merged commit 5d98cee into 2.12.x Dec 5, 2023
10 of 12 checks passed
@MiguelCompany MiguelCompany deleted the backport/4036-4052 branch December 5, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

@EduPonz EduPonz Awaiting requested review from EduPonz

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @elianalf @EduPonz