-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19024] Expose Payload Pool on DDS layer: Implementation #3740
Merged
JesusPoderoso
merged 1 commit into
feature/custom-pools/main
from
feature/custom-pools/impl
Jul 27, 2023
Merged
[19024] Expose Payload Pool on DDS layer: Implementation #3740
JesusPoderoso
merged 1 commit into
feature/custom-pools/main
from
feature/custom-pools/impl
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
feature/custom-pools/impl
branch
from
July 24, 2023 08:54
d7469b0
to
381cca4
Compare
JesusPoderoso
force-pushed
the
feature/custom-pools/impl
branch
from
July 24, 2023 08:56
381cca4
to
b757ce0
Compare
@richiprosima please test this |
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/custom-pools/impl
branch
from
July 26, 2023 08:21
b757ce0
to
aa20cfd
Compare
@richiprosima please test this |
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jul 27, 2023
EduPonz
pushed a commit
that referenced
this pull request
Aug 3, 2023
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
jimwang118
pushed a commit
to jimwang118/Fast-DDS
that referenced
this pull request
Aug 22, 2023
* Custom Payload pools test implementation (eProsima#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (eProsima#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Nov 10, 2023
* Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
rsanchez15
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
rsanchez15
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Custom pools on DDS layer feature (#3755) * Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> * Add API to create writers and readers with a custom payload pool Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Use correct API in tests Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Fix Window warning about asio include Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Remove feature in forthcoming version file Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Add Asio include dir to datareader tests Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Custom pools on DDS layer feature (#3755) * Custom Payload pools test implementation (#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> * Add API to create writers and readers with a custom payload pool Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Use correct API in tests Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aim to expose the usage of a custom payload pool implementation on the DDS layer, and implements the functionality
Contributor Checklist
Test are implemented in this PR: [19023] Custom Payload pools test implementation #3719
versions.md
file (if applicable).Related documentation PR: [18913] Expose PayloadPool in DDSDataWriter and DDSDataReader Fast-DDS-docs#514
Reviewer Checklist