[15905] Fix dataraces when creating DataWriters (backport #3008) #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
10 tasks
EduPonz
force-pushed
the
mergify/bp/2.3.x/pr-3008
branch
3 times, most recently
from
c22b306
to
81079ba
Compare
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864)
EduPonz
force-pushed
the
mergify/bp/2.3.x/pr-3008
branch
from
81079ba
to
d887485
Compare
|
@richiprosima Please test this |
MiguelCompany
added
ci-pending
|
@Mergifyio backport 2.1.x |
mergify bot
added a commit
that referenced
this pull request
Oct 28, 2022
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864) Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit 90777ec) # Conflicts: # test/blackbox/common/RTPSBlackboxTestsBasic.cpp
✅ Backports have been created
|
MiguelCompany
added a commit
that referenced
this pull request
Nov 3, 2022
* Fix dataraces when creating DataWriters (#3015) * Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864) Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit 90777ec) # Conflicts: # test/blackbox/common/RTPSBlackboxTestsBasic.cpp * Fixed conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fix build on RTPSBlackboxTestsBasic.cpp Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3008 done by Mergify.
Cherry-pick of 4391864 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com