Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15600] Correct initialization order warning in DomainParticipantImpl mock #2995

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Sep 29, 2022

Signed-off-by: Eduardo Ponz eduardoponz@eprosima.com

Description

This PRs corrects an initialization order warning in DomainParticipantImpl

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 ci-pending PR which CI is running labels Sep 29, 2022
@EduPonz EduPonz added this to the v2.8.0 milestone Sep 29, 2022
jsan-rt
jsan-rt previously approved these changes Sep 29, 2022
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link
Author

EduPonz commented Sep 29, 2022

@richiprosima please test windows

@MiguelCompany
Copy link
Member

@Mergifyio rebase

…tImpl mock

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

rebase

✅ Branch has been successfully rebased

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@EduPonz EduPonz merged commit bcacaf1 into master Sep 29, 2022
@EduPonz EduPonz deleted the hotfix/statistics_mock_warning branch September 29, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants