Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15493] Android Improvements #2977

Merged
merged 6 commits into from
Sep 26, 2022
Merged

[15493] Android Improvements #2977

merged 6 commits into from
Sep 26, 2022

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Sep 26, 2022

Description

While Fast DDS already supported Android this PR improves some of its behavior regarding Boost and Shared Memory.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jsan-rt
Refs #15493: Improvements to Android SHM handling. Minor fixes.
2cb2b93 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #15493: Reverted Datasharing autodisabling on Android when using…
5a548b7 
… wrong folder

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #15493: Removed overly cautious path correction
09e08e8 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt mentioned this pull request Sep 26, 2022
Merged
13 tasks
@jsan-rt
Refs #15493: Applied suggestions
176c5a8 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Refs #15493: Removed unneeded flags reported by Clang
1aed164 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@jsan-rt
Refs #15493: Fixed typo
6a8c85f 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany merged commit f8c6641 into master Sep 26, 2022
@MiguelCompany MiguelCompany deleted the feature/android-common-improvements branch September 26, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsan-rt @MiguelCompany