Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std::string::compare API to fixed_string [15351] #2901

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Add std::string::compare API to fixed_string [15351] #2901

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e04e814
Refs #15294. Add std::string::compare api
richiware Aug 3, 2022
1f299d3
Refs #15294. Add doxygen
richiware Aug 3, 2022
a4d80e5
Refs #15294. Fixed typo
richiware Aug 3, 2022
6177ad3
Refs #15294. Add suggested functions
richiware Aug 4, 2022
83e0c96
Refs #15294. Add unit test
richiware Aug 4, 2022
0eec881
Refs #15294. Fix typo
richiware Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions include/fastrtps/utils/fixed_size_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,13 @@ struct fixed_string
return string_len;
}

/*!
* Compare with a std:.string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo: std::string instead of std:.string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in a4d80e5

*
* @param str std::string to be compared with.
*
* @return Integer value with the result of the comparison as described in `std.:string::compare()`.
*/
int compare(
const std::string& str ) const
MiguelCompany marked this conversation as resolved.
Show resolved Hide resolved
{
Expand Down