Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15025] Improvements thread sanitizer workflow #2820

Merged
merged 3 commits into from
Jul 7, 2022
Merged

[15025] Improvements thread sanitizer workflow #2820

merged 3 commits into from
Jul 7, 2022

Conversation

MiguelBarro
Copy link
Contributor

Description

Prevent workflow run on:

  • no-test flag selected
  • non-sources (including cmake) changes

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [] NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • NA Any new/modified methods have been properly documented using Doxygen.
  • NA Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Miguel Barro added 2 commits July 6, 2022 14:16
Refs 15025. Dont' run CI if no-test label is enforced or non-sources …
0e72f1c 
…are modified

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Refs 15025. Python & powershell scripts are sources too.
d88c7b2 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro self-assigned this Jul 6, 2022
@MiguelCompany MiguelCompany added skip-ci Automatically pass CI no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI no-test Skip CI tests if PR marked with this label labels Jul 6, 2022
Refs 15025. blacklist approach to the path && add skip-ci flag
4dfa09e 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany merged commit 5e2949c into master Jul 7, 2022
@MiguelCompany MiguelCompany deleted the testing/action_labels branch July 7, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@MiguelBarro MiguelBarro

Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelBarro @MiguelCompany