Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15013] Add SNI API #2763

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[15013] Add SNI API #2763

merged 1 commit into from
Jun 28, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jun 20, 2022 •
edited by EduPonz
Loading

Description

This PR adds the required API for later implementation of Server Name Indication (SNI).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally. [15013] Add SNI configuration to TLSConfig Fast-DDS-docs#375
  • N/A: New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15
Refs #14919: Add SNI API
9a2ba70 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15 rsanchez15 added this to the v2.7.0 milestone Jun 20, 2022
@EduPonz EduPonz added the doc-pending Issue or PR which is pending to be documented label Jun 27, 2022
@rsanchez15
Copy link
Contributor Author

Documentation can be found in this PR: eProsima/Fast-DDS-docs#375

@rsanchez15 rsanchez15 removed the doc-pending Issue or PR which is pending to be documented label Jun 27, 2022
@EduPonz EduPonz mentioned this pull request Jun 28, 2022
Merged
@EduPonz EduPonz changed the title Add SNI API [15013] Add SNI API Jun 28, 2022
@EduPonz EduPonz merged commit 1bbeb29 into master Jun 28, 2022
@EduPonz EduPonz deleted the feature/sni-api branch June 28, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @MiguelCompany @EduPonz