Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14770] SampleRejectedStatus feature #2708

Merged
merged 22 commits into from
Jun 13, 2022
Merged

[14770] SampleRejectedStatus feature #2708

merged 22 commits into from
Jun 13, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented May 31, 2022 •
edited by MiguelCompany
Loading

Signed-off-by: Ricardo González Moreno ricardo@richiware.dev

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 mentioned this pull request Jun 1, 2022
Merged
@MiguelCompany MiguelCompany changed the title SampleRejectedStatus feature [14770] SampleRejectedStatus feature Jun 3, 2022
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Jun 3, 2022
MiguelCompany
MiguelCompany requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review: implementation only

include/fastdds/rtps/common/CacheChange.h Show resolved Hide resolved
include/fastdds/rtps/history/ReaderHistory.h Show resolved Hide resolved
include/fastdds/rtps/history/ReaderHistory.h Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.cpp Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.hpp Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.hpp Show resolved Hide resolved
@MiguelCompany MiguelCompany added the no-aarch Skip build & test for aarch64 label Jun 3, 2022
@richiware richiware force-pushed the feature/sample-rejected branch 2 times, most recently from 52b073d to 0c011bd Compare June 7, 2022 08:49
@MiguelCompany
Copy link
Member

@richiprosima Please test linux

MiguelCompany
MiguelCompany requested changes Jun 7, 2022
View reviewed changes
include/fastdds/rtps/common/CacheChange.h Show resolved Hide resolved
include/fastdds/rtps/history/ReaderHistory.h Show resolved Hide resolved
include/fastdds/rtps/history/ReaderHistory.h Show resolved Hide resolved
src/cpp/fastdds/subscriber/DataReaderImpl.hpp Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.hpp Outdated Show resolved Hide resolved
versions.md Outdated Show resolved Hide resolved
MiguelCompany
MiguelCompany previously approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware richiware mentioned this pull request Jun 8, 2022
Merged
@EduPonz EduPonz added skip-ci Automatically pass CI and removed no-aarch Skip build & test for aarch64 labels Jun 10, 2022
@richiware @MiguelCompany
Refs #14590. Initial commit
7db48b1 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Add tests for max_sample
492156d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Tests for max_samples_per_instance
d6e3555 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix impl for max_samples_per_instance
32cd92a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Add test for max_instances
968d725 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Implemented max_instances
b56b5e4 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix compilation warnings
aa8aeca 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Remove unused function.
18717d3 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Use again RTPS_DllAPI
e0005e4 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix get_sample_rejected_status
fe5b5ea 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix doxygen doc
226e736 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Added comment in a removed assert
3e0e9b5 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Remove unnecessary code after rebasing
5cc5a89 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Trying to lose less fragments in tests
e744883 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Add test for waitsets.
bbc3030 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Apply suggestions
edb221b 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Update versions.md
05f7268 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix warnings on mac
717ed0d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix random failing test
5e89a5d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Apply suggestions
7c328fa 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @MiguelCompany
Refs #14590. Fix versions.md
7bb13da 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany
Refs #14590. Fix doxydoc.
322d554 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 and removed skip-ci Automatically pass CI labels Jun 10, 2022
@MiguelCompany MiguelCompany removed the no-test Skip CI tests if PR marked with this label label Jun 10, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@EduPonz EduPonz merged commit 03d0f3b into master Jun 13, 2022
@EduPonz EduPonz deleted the feature/sample-rejected branch June 13, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @MiguelCompany @EduPonz