-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14749] Solving sanitizer issue 4139 <master> #2685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelBarro
changed the title
Solving sanitizer issue 4139
Solving sanitizer issue 4139 <master>
May 19, 2022
MiguelBarro
force-pushed
the
test/issue/4139
branch
from
May 26, 2022 13:24
701b850
to
f8c0503
Compare
MiguelBarro
changed the title
Solving sanitizer issue 4139 <master>
[14749] Solving sanitizer issue 4139 <master>
Jun 2, 2022
MiguelBarro
force-pushed
the
test/issue/4139
branch
2 times, most recently
from
June 3, 2022 11:31
ec2218b
to
c1744b2
Compare
MiguelBarro
added
skip-ci
Automatically pass CI
no-aarch
Skip build & test for aarch64
labels
Jun 6, 2022
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro
force-pushed
the
test/issue/4139
branch
from
June 6, 2022 13:44
c1744b2
to
231eaae
Compare
jsan-rt
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MiguelCompany
added
no-test
Skip CI tests if PR marked with this label
and removed
skip-ci
Automatically pass CI
labels
Jun 6, 2022
@richiprosima Please test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sanitizer CI see #2679
Description
LivelinessManager should be refactored in order to solve lock inversion issues reported in several issues like 4139.
The class has now a
devoted to safeguarding the class data (including member collection contents). And a
devoted to protecting member collections and allowing their safe traversal without taking any writer lock that will lead to lock inversion.
The code was reordered in order to prevent any callbacks (potencial deadlock sources) with any
lock
taken (onlyshared_lock
or none is allowed.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist