Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14361] Improve ParticipantTests with ContentFilteredTopic #2634

Merged

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Apr 12, 2022

Description

#2521 added ContentFilteredTopics into Fast DDS. Some DomainParticipant unit tests were not updated taking into account this new feature. This PR improves two of these tests:

  • DeleteTopicInUse: check that even if no endpoints are created in the Topic, Topic deletion fails if there is a ContentFilteredTopic created using this specific Topic.
  • DeleteContainedEntities: check that DomainParticipant::delete_contained_entities also takes charge of gracefully deleting the ContentFilteredTopic allowing the Topic to be deleted as well.

@Mergifyio backport 2.5.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JLBuenoLopez
Copy link
Contributor Author

Test failures are unrelated

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 13, 2022
@MiguelCompany MiguelCompany merged commit a6a6258 into master Apr 13, 2022
@MiguelCompany MiguelCompany deleted the hotfix/fix_participant_tests_contentfilteredtopic branch April 13, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants