Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for ContentFilterTopic [14220] #2596

Merged
merged 17 commits into from
Apr 12, 2022
Merged

Add examples for ContentFilterTopic [14220] #2596

merged 17 commits into from
Apr 12, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Mar 23, 2022 •
edited by EduPonz
Loading

Description

This PR adds two examples related to ContentFilterTopic:

  • DefaultSQLFilter: example using the built-in SQL-like filter.
  • CustomFilter: example using a custom filter.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • na Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • na Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • na New feature has been added to the versions.md file (if applicable).
  • na New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #13791. Add DefaultSQLFilter example
36ce314 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #13791. Add CustomFilter example
0d7682b 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Add examples for ContentFilterTopic Add examples for ContentFilterTopic [14220] Mar 23, 2022
@JLBuenoLopez
Copy link
Contributor

CI failures are unrelated to the PR. Linters are failing in an autogenerated file so it is a false positive.

jparisu
jparisu suggested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add README.md file with a brief explanation

JLBuenoLopez
JLBuenoLopez suggested changes Apr 6, 2022
View reviewed changes
examples/C++/DDS/ContentFilterTopic/DefaultSQLFilterPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/DefaultSQLFilterPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/DefaultSQLFilterPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/DefaultSQLFilterSubscriber.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/DefaultSQLFilterSubscriber.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/CMakeLists.txt Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/CustomFilterSubscriber.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/CustomFilterSubscriber.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/CustomFilterSubscriber.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilterTopic/CustomFilterSubscriber.cpp Outdated Show resolved Hide resolved
@JLBuenoLopez
Copy link
Contributor

Please, add README.md file with a brief explanation

A description of the custom filter should also be included in the README

@JLBuenoLopez
Refs #14220: rename example. First step to unify both examples into t…
51e0cc1 
…he same one with an user option indicating which filter to use (default SQL or custom one)

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: infrastructure to run either the default or the custom f…
4171687 
…ilter. Default filter expression has been modified to filter different messages than the custom filter

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: fix installation folder
62eb6f1 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: add example README
892cb1a 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: apply review suggestions
6cb6843 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
jparisu
jparisu previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README Revised 👍

@JLBuenoLopez
Refs #14220: linters
3a9c5a0 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

CI failures are unrelated (changes does not affect library's code)

EduPonz
EduPonz suggested changes Apr 7, 2022
View reviewed changes
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.hpp Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.cpp Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExampleSubscriber.cpp Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
@JLBuenoLopez
Refs #14220: Use argument parser
bd054f5 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: apply code review suggestions
fa76a98 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: linters
662745f 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: fix argument parser if option is unknown
1f8b869 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: improve documentation
b011328 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: apply review suggestions to README
40b5423 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #14220: fix clang error
7087a85 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
EduPonz suggested changes Apr 11, 2022
View reviewed changes
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExamplePublisher.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExample_main.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/ContentFilteredTopicExample_main.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/MyCustomFilter.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/MyCustomFilterFactory.hpp Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/MyCustomFilterFactory.hpp Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/ContentFilteredTopicExample/README.md Outdated Show resolved Hide resolved
@JLBuenoLopez
Refs #14220: apply new review suggestion batch
61a54b1 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Apr 11, 2022
@JLBuenoLopez
Refs #14220: fix building error
33813b1 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
EduPonz
EduPonz approved these changes Apr 11, 2022
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit 56f9f5a into master Apr 12, 2022
@EduPonz EduPonz deleted the feature/contentfilter-example branch April 12, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

@jparisu jparisu jparisu left review comments

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richiware @JLBuenoLopez @EduPonz @jparisu