Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #13972: Fix GuidPrefix fail case in >>operator [13972] #2530

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Feb 28, 2022

Fix GuidPrefix fail case in >>operator

Description

GuidPrefix_t class has a deserialization method >> operator that does not fail in case an incorrect string format is passed.
This is fixed by returning an unknown (invalid) GuidPrefix.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu added the bug Issue to report a bug label Feb 28, 2022
@jparisu
Copy link
Contributor Author

jparisu commented Feb 28, 2022

There are no tests for GuidPrefix_t, so no tests are added

@EduPonz EduPonz added this to the v2.6.1 milestone Jun 1, 2022
@EduPonz EduPonz self-assigned this Jun 1, 2022
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit cb8b84a into master Jun 7, 2022
@EduPonz EduPonz deleted the hotfix/guidprefix-deserialization branch June 7, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to report a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants