Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs 13882. Fixes for _UNICODE macro on Visual Studio #2510

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Feb 17, 2022

Select the right windows API functions independently of the _UNICODE preprocessor definition.
This addresses the issue #2501

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 49e7986 into master Feb 18, 2022
@MiguelCompany MiguelCompany deleted the bugfix/windows/unicode branch February 18, 2022 06:02
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.4.x 2.3.x 2.1.x

mergify bot pushed a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 49e7986)
mergify bot pushed a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 49e7986)
mergify bot pushed a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 49e7986)

# Conflicts:
#	src/cpp/utils/SystemInfo.cpp
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2022

backport 2.4.x 2.3.x 2.1.x

✅ Backports have been created

MiguelBarro added a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro added a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro added a commit that referenced this pull request Feb 18, 2022
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants