Enable memory protection on DataSharing readers [13457] #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
changed the title
JLBuenoLopez
approved these changes
Feb 8, 2022
JLBuenoLopez
added
the
ready-to-merge
|
@Mergifyio backport 2.4.x 2.3.x |
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Refs 13457. DataSharing reader map memory as read only. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Allow disabling non-const accessor on LoanableSequence. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. New macro FASTDDS_CONST_SEQUENCE. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Use FASTDDS_CONST_SEQUENCE on zero copy example. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 6505a51)
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Refs 13457. DataSharing reader map memory as read only. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Allow disabling non-const accessor on LoanableSequence. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. New macro FASTDDS_CONST_SEQUENCE. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Use FASTDDS_CONST_SEQUENCE on zero copy example. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 6505a51) # Conflicts: # src/cpp/rtps/DataSharing/ReaderPool.hpp # src/cpp/utils/shared_memory/SharedMemSegment.hpp
✅ Backports have been created
|
MiguelCompany
added a commit
that referenced
this pull request
Feb 9, 2022
* Enable memory protection on DataSharing readers (#2405) * Refs 13457. DataSharing reader map memory as read only. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Allow disabling non-const accessor on LoanableSequence. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. New macro FASTDDS_CONST_SEQUENCE. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Use FASTDDS_CONST_SEQUENCE on zero copy example. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13457. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 6505a51) # Conflicts: # src/cpp/rtps/DataSharing/ReaderPool.hpp # src/cpp/utils/shared_memory/SharedMemSegment.hpp * Fix conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several safety protection mechanisms on DataReader entities using data-sharing.
First, the readers will open the shared history on read-only mode.
Second, a new FASTDDS_CONST_SEQUENCE macro to define a sequence that only has the
constversion of the[]operator.Should fix #2385