Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bad_node_size exception when cross building [12583] #2229

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

MiguelCompany
Copy link
Member

When foonathan/memory is cross-compiled, and the node_size_dbg tool cannot be executed with an emulator, some custom node types are used to calculate the size of the nodes being requested to the allocator.

After some reports of a bad_node_size exception being thrown, I investigated this deeply, and found the custom type was not compliant with certain std implementations (libstdc++).

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title Avoid bad_node_size exception when cross building Avoid bad_node_size exception when cross building [12583] Sep 24, 2021
@foonathan
Copy link

This will permanently fix foonathan/memory#103, foonathan/memory#123.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.3.x 2.2.x 2.1.x

@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2021

Command backport 2.3.x 2.2.x 2.1.x: pending

backport 2.3.x 2.2.x 2.1.x is pending

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 1484609 into master Sep 27, 2021
@MiguelCompany MiguelCompany deleted the bugfix/custom-tree-node branch September 27, 2021 06:26
mergify bot pushed a commit that referenced this pull request Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 12583. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 1484609)
mergify bot pushed a commit that referenced this pull request Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 12583. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 1484609)
mergify bot pushed a commit that referenced this pull request Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 12583. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 1484609)
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2021

Command backport 2.3.x 2.2.x 2.1.x: success

Backports have been created

pablorcum pushed a commit to pablorcum/Fast-DDS that referenced this pull request Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 12583. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants