Avoid a volatile datasharing reader blocks a writer [12222] (backport #2090) #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #11743. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Volatire reader know acks samples in the writer pool Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix error Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix compilation error with new flow controllers Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix segmentation fault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit c97053e)
MiguelCompany
previously approved these changes
Sep 7, 2021
|
@richiprosima Please test this |
1 similar comment
|
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
previously approved these changes
Sep 7, 2021
|
@richiware would you mind fixing build errors here? |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
@richiprosima Please test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2090 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/