Skip to content

Commit

Permalink
Test report action does not run when no-test label is set (#4366)
Browse files Browse the repository at this point in the history
* Refs #20400: Test report action does not run when no-test label is set

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Add GTest cmake options to nightly.meta

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Use test step conclusion to decide whether to run test report step

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20400: Apply Miguel's suggestion

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
  • Loading branch information
EduPonz committed Feb 14, 2024
1 parent 0a9f35f commit ec1dadf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/config/nightly.meta
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,8 @@ names:
- "-DTHIRDPARTY_UPDATE=ON"
- "-DMEMORYCHECK_COMMAND_OPTIONS=-q --tool=memcheck --leak-check=yes --show-reachable=yes --num-callers=50 --log-fd=2 --error-exitcode=1"
- "-DMEMORYCHECK_SUPPRESSIONS_FILE=../../src/fastrtps/valgrind.supp"
googletest-distribution:
cmake-args:
- "-Dgtest_force_shared_crt=ON"
- "-DBUILD_SHARED_LIBS=ON"
- "-DBUILD_GMOCK=ON"
2 changes: 1 addition & 1 deletion .github/workflows/reusable-windows-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ jobs:

- name: Test Report
uses: eProsima/eProsima-CI/external/test-reporter@main
if: success() || failure()
if: ${{ !cancelled() && !contains(github.event.pull_request.labels.*.name, 'no-test') }}
with:
name: "Report: ${{ matrix.cmake-config }} | ${{ matrix.vs-toolset }} "
path: "${{ steps.test.outputs.ctest_results_path }}*.xml"
Expand Down

0 comments on commit ec1dadf

Please sign in to comment.