Skip to content

Commit

Permalink
Refs #19452: fixes after rebase
Browse files Browse the repository at this point in the history
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
  • Loading branch information
JLBuenoLopez committed Jan 30, 2024
1 parent 42e202d commit 9c63223
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/cpp/rtps/builtin/data/ParticipantProxyData.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ bool ParticipantProxyData::readFromCDRMessage(
// TODO(eduponz): This is a workaround for the moment, as it is implicitly assuming
// that the vendor ID parameter came before this one. In the future, we should propagate
// the vendor ID from the RTPS message header using the CacheChange and check it here.
FASTDDS_TODO_BEFORE(2, 14, "Add vendor ID to CacheChange");
// FASTDDS_TODO_BEFORE(2, 14, "Add vendor ID to CacheChange");
if (c_VendorId_eProsima != m_VendorId)
{
return true;
Expand Down
3 changes: 2 additions & 1 deletion test/performance/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ option(VIDEO_TESTS "Activate the building and execution of performance tests" OF
add_subdirectory(latency)
add_subdirectory(throughput)
if(VIDEO_TESTS)
add_subdirectory(video)
# // TODO(jlbueno): migrate to Fast DDS API
# add_subdirectory(video)
endif()
2 changes: 1 addition & 1 deletion test/performance/video/VideoTestSubscriber.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include <numeric>
#include <thread>

#include <fastdds/dds/log/Colors.h>
#include <fastdds/dds/log/Colors.hpp>
#include <fastdds/dds/log/Log.hpp>
#include <fastrtps/xmlparser/XMLProfileManager.h>

Expand Down
10 changes: 5 additions & 5 deletions test/unittest/transport/TCPv4Tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1895,16 +1895,16 @@ TEST_F(TCPv4Tests, autofill_port)
// process this lead to overwriting server's channel resources map elements.
TEST_F(TCPv4Tests, client_announced_local_port_uniqueness)
{
TCPv4TransportDescriptor recvDescriptor;
eprosima::fastdds::rtps::TCPv4TransportDescriptor recvDescriptor;
recvDescriptor.add_listener_port(g_default_port);
MockTCPv4Transport receiveTransportUnderTest(recvDescriptor);
receiveTransportUnderTest.init();

TCPv4TransportDescriptor sendDescriptor_1;
eprosima::fastdds::rtps::TCPv4TransportDescriptor sendDescriptor_1;
TCPv4Transport sendTransportUnderTest_1(sendDescriptor_1);
sendTransportUnderTest_1.init();

TCPv4TransportDescriptor sendDescriptor_2;
eprosima::fastdds::rtps::TCPv4TransportDescriptor sendDescriptor_2;
TCPv4Transport sendTransportUnderTest_2(sendDescriptor_2);
sendTransportUnderTest_2.init();

Expand All @@ -1914,11 +1914,11 @@ TEST_F(TCPv4Tests, client_announced_local_port_uniqueness)
outputLocator.port = g_default_port;
IPLocator::setLogicalPort(outputLocator, 7410);

SendResourceList send_resource_list_1;
eprosima::fastdds::rtps::SendResourceList send_resource_list_1;
ASSERT_TRUE(sendTransportUnderTest_1.OpenOutputChannel(send_resource_list_1, outputLocator));
ASSERT_FALSE(send_resource_list_1.empty());

SendResourceList send_resource_list_2;
eprosima::fastdds::rtps::SendResourceList send_resource_list_2;
ASSERT_TRUE(sendTransportUnderTest_2.OpenOutputChannel(send_resource_list_2, outputLocator));
ASSERT_FALSE(send_resource_list_2.empty());

Expand Down
4 changes: 2 additions & 2 deletions test/unittest/transport/TCPv6Tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -239,11 +239,11 @@ TEST_F(TCPv6Tests, client_announced_local_port_uniqueness)
outputLocator.port = g_default_port;
IPLocator::setLogicalPort(outputLocator, 7610);

SendResourceList send_resource_list_1;
eprosima::fastdds::rtps::SendResourceList send_resource_list_1;
ASSERT_TRUE(sendTransportUnderTest_1.OpenOutputChannel(send_resource_list_1, outputLocator));
ASSERT_FALSE(send_resource_list_1.empty());

SendResourceList send_resource_list_2;
eprosima::fastdds::rtps::SendResourceList send_resource_list_2;
ASSERT_TRUE(sendTransportUnderTest_2.OpenOutputChannel(send_resource_list_2, outputLocator));
ASSERT_FALSE(send_resource_list_2.empty());

Expand Down

0 comments on commit 9c63223

Please sign in to comment.