Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20629] GUIDLess Discovery Server - Make ServerAttributes private #147

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[20629] GUIDLess Discovery Server - Make ServerAttributes private #147

merged 1 commit into from
Jul 3, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 20, 2024 •
edited by MiguelCompany
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v2.0.0 milestone Jun 20, 2024
@cferreiragonz cferreiragonz mentioned this pull request Jun 20, 2024
Merged
12 tasks
MiguelCompany
MiguelCompany previously approved these changes Jun 25, 2024
View reviewed changes
@cferreiragonz
Refs #20629: Make ServerAttributes private
373048f 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the feature/mesh_ds_guid_less_3.0.x branch from 94d9e52 to 373048f Compare June 28, 2024 06:49
@MiguelCompany MiguelCompany merged commit 93c94a1 into main Jul 3, 2024
2 of 4 checks passed
@MiguelCompany MiguelCompany deleted the feature/mesh_ds_guid_less_3.0.x branch July 3, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany