Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21077] Update Fast DDS docs QoS examples #145

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[21077] Update Fast DDS docs QoS examples #145

merged 1 commit into from
Jun 20, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 19, 2024 •
edited by EduPonz
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz
Refs #21077: Update python tests
0bec31e 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz mentioned this pull request Jun 19, 2024
Merged
8 tasks
@cferreiragonz cferreiragonz changed the title [21077] Review Fast DDS docs QoS examples [21077] Update Fast DDS docs QoS examples Jun 19, 2024
Tempate
Tempate approved these changes Jun 20, 2024
View reviewed changes
Copy link

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit ad827a8 into main Jun 20, 2024
4 checks passed
@EduPonz EduPonz deleted the qos_api_review branch June 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@Tempate Tempate Tempate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cferreiragonz @EduPonz @Tempate