Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic TypeObject representation registration for DynamicTypes [21058] #130

Merged
merged 1 commit into from
May 20, 2024
Merged

Automatic TypeObject representation registration for DynamicTypes [21058] #130

merged 1 commit into from
May 20, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented May 20, 2024 •
edited by EduPonz
Loading

Description

Regeneration of IDL source code to compile against eProsima/Fast-DDS#4746

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #20853. Regenerate code
9cca9d4 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Automatic TypeObject representation registration for DynamicTypes Automatic TypeObject representation registration for DynamicTypes [21058] May 20, 2024
@richiware
Copy link
Member Author

✅ Passed manual ci. Error is unrelated. Build and tests passed.

adriancampo
adriancampo approved these changes May 20, 2024
View reviewed changes
Copy link

@adriancampo adriancampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit f5bd489 into main May 20, 2024
2 of 6 checks passed
@richiware richiware deleted the feature/register_typeobject_w_dynamictype branch May 20, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriancampo adriancampo adriancampo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @adriancampo