Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21416] Fix sphinx-toolbox version in requirements.txt #920

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

depink5
Copy link
Contributor

@depink5 depink5 commented Sep 26, 2024

After merging the FAQ section into the master branch, the readthedocs build fails at this step.

python -m sphinx -T -b readthedocssinglehtmllocalmedia -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/htmlzip

After research, it appears that the sphinx-toolbox 3.7.0 is not correctly read during build. Therefore, this PR updates the sphinx-toolbox version to 3.8.0.

sphinx-toolbox/sphinx-toolbox#169

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Signed-off-by: Denisa <denisa@eprosima.com>
@depink5 depink5 changed the title Fix sphinx-toolbox version in requirements.txt [21416] Fix sphinx-toolbox version in requirements.txt Sep 26, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.2 milestone Sep 26, 2024
@JesusPoderoso JesusPoderoso self-requested a review September 26, 2024 14:08
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
LGTM with green CI

@JesusPoderoso JesusPoderoso merged commit dac125e into master Sep 27, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the fix/requirements.txt-sphinx-toolbox-version branch September 27, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants