Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21590] Add warning about idls extensibility for Vulcanexus jazzy #906

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[21590] Add warning about idls extensibility for Vulcanexus jazzy #906

merged 4 commits into from
Sep 9, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 6, 2024 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL
Refs #21590: Add warning about the extensibility when using fastddsge…
b37254e 
…n for generating ros 2 types

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.0.1 - Frozen ❄️ milestone Sep 6, 2024
@JesusPoderoso JesusPoderoso self-requested a review September 9, 2024 09:43
@JesusPoderoso
Refs #21590: Apply rev suggestions
661bd1f 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21590: Fix linter and use inline code snippets properly
a77108d 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso self-requested a review September 9, 2024 11:56
JesusPoderoso
JesusPoderoso previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso mentioned this pull request Sep 9, 2024
Merged
@JesusPoderoso
Refs #21590: Restore '@Final'
9c7d953 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso self-requested a review September 9, 2024 12:29
@JesusPoderoso JesusPoderoso merged commit 6c1fee0 into master Sep 9, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the docs/21590 branch September 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @JesusPoderoso