Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21580] Improve mutation_tries documentation (backport #768) #904

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 6, 2024

Description

This PR improves the usage and definition of mutation_tries and gives extra information about the participantId usage too.

@Mergifyio backport 2.14.x 2.10.x 2.6.x

Fixes eProsima/Fast-DDS#4754

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #768 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Sep 6, 2024
Copy link
Author

mergify bot commented Sep 6, 2024

Cherry-pick of 26b6700 has failed:

On branch mergify/bp/2.14.x/pr-768
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 26b6700.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   code/XMLTester.xml
	modified:   docs/fastdds/transport/listening_locators.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   code/DDSCodeTester.cpp
	both modified:   docs/fastdds/dds_layer/core/policy/eprosimaExtensions.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@JesusPoderoso JesusPoderoso added this to the v2.14.4 milestone Sep 6, 2024
@JesusPoderoso JesusPoderoso force-pushed the mergify/bp/2.14.x/pr-768 branch from a9693c4 to 006dac4 Compare September 6, 2024 05:53
@JesusPoderoso JesusPoderoso self-requested a review September 6, 2024 05:58
* Refs #20934: Improve documentation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20934: Apply internal rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #20934: Update namespaces

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21580: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21580: Apply rev suggestions (2)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 26b6700)

# Conflicts:
#	code/DDSCodeTester.cpp
#	docs/fastdds/dds_layer/core/policy/eprosimaExtensions.rst
@JesusPoderoso JesusPoderoso force-pushed the mergify/bp/2.14.x/pr-768 branch from 006dac4 to f67d63f Compare September 6, 2024 05:59
@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso September 6, 2024 05:59
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso merged commit 0af9262 into 2.14.x Sep 6, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the mergify/bp/2.14.x/pr-768 branch September 6, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant