Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21378] Refactor TopicDataType #875

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[21378] Refactor TopicDataType #875

merged 3 commits into from
Jul 18, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 17, 2024 •
edited by MiguelCompany
Loading

Description

This PR update the source code to new changes introduced in:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@richiware richiware changed the title Update to new TopicDataType functions [21378] Update to new TopicDataType functions Jul 17, 2024
@richiware richiware mentioned this pull request Jul 17, 2024
Merged
8 tasks
@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jul 17, 2024
@richiware
Refs #21349. Generate source code
4984b7a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #21349. Regenerate source code
2ec907d 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #21349. Fix compilation
7b76b36 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany July 17, 2024 14:00
MiguelCompany
MiguelCompany approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany changed the title [21378] Update to new TopicDataType functions [21378] Refactor TopicDataType Jul 18, 2024
@MiguelCompany MiguelCompany self-requested a review July 18, 2024 10:10
@richiware richiware merged commit bc130df into master Jul 18, 2024
5 checks passed
@richiware richiware deleted the feature/21349 branch July 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany