Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21121] IPayloadPool refactor #800

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[21121] IPayloadPool refactor #800

merged 4 commits into from
Jun 12, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 5, 2024 •
edited by MiguelCompany
Loading

Description

This PR updates the code examples that implement a CustomPayloadPool after the changes in IPayloadPool and derived classes.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@cferreiragonz cferreiragonz added this to the v3.0.0 milestone Jun 5, 2024
@cferreiragonz cferreiragonz mentioned this pull request Jun 5, 2024
Merged
11 tasks
@cferreiragonz cferreiragonz force-pushed the feature/ipayloadpool_refactor branch from 73607d2 to 067bce8 Compare June 11, 2024 08:57
@MiguelCompany
Copy link
Member

@richiprosima Please test_3 docs

MiguelCompany
MiguelCompany requested changes Jun 11, 2024
View reviewed changes
@MiguelCompany
Copy link
Member

@richiprosima Please test_3 docs

@cferreiragonz
Refs #21121: Update API
6ac52e1 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #21121: Revision - remove getters/setter
94dbdb5 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #21121: Make get_payload's first arg const
ccf7e49 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #21121: Revision
3d4ee15 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the feature/ipayloadpool_refactor branch from 801c99a to 3d4ee15 Compare June 11, 2024 14:29
@cferreiragonz
Copy link
Contributor Author

@richiprosima Please test_3 docs

@MiguelCompany MiguelCompany merged commit 6802780 into master Jun 12, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/ipayloadpool_refactor branch June 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany