Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade cmake version to 3.20 #727

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Downgrade cmake version to 3.20 #727

merged 1 commit into from
Mar 14, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Mar 13, 2024 •
edited by EduPonz
Loading

Description

Downgrade cmake version to 3.20 in code/Examples/c++/DDSHelloWorld/CMakeList.txt and upgrade 3.12 in CMakeList.txt
Reference PR in docs master:

Related fastdds PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • N/A Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf
Refs #20176: downgrade/upgrade cmake version to 3.20
399eb79 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v2.12.2 milestone Mar 13, 2024
JesusPoderoso
JesusPoderoso approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso mentioned this pull request Mar 13, 2024
Merged
6 tasks
@EduPonz EduPonz merged commit 34729df into 2.12.x Mar 14, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/downgrade_cmake_version_2_12_x branch March 14, 2024 06:05
@elianalf elianalf mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v2.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @JesusPoderoso @EduPonz