Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20493] Extend LARGE_DATA configuration options #696

Merged
merged 15 commits into from
Mar 7, 2024
Merged

[20493] Extend LARGE_DATA configuration options #696

merged 15 commits into from
Mar 7, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Feb 28, 2024 •
edited by JesusPoderoso
Loading

Description

This PR updates documentation to include the new feature regarding the Builtin Transports Options introduced in PR: eProsima/Fast-DDS#4444.

It affects:

  • RTPSParticipant and DomainParticipant API.
  • XML profiles
  • Environment variable
  • New case of use using the Builtin Transports Options

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@cferreiragonz cferreiragonz mentioned this pull request Feb 28, 2024
Merged
11 tasks
@JesusPoderoso JesusPoderoso added this to the v2.14.0 milestone Feb 28, 2024
@cferreiragonz cferreiragonz force-pushed the feature/large_data_config_options branch from 7d625f8 to c475bad Compare February 29, 2024 07:38
@cferreiragonz
Refs #20493: Update XML examples
33dec1c 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Add new XML type
b954953 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update API code example
be019d7 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update Env.var. section with options
3eb91c3 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: New TCP use case with LARGE_DATA options
33e7122 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Fix XML files
7c011a3 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Add troubleshooting and SHM segment size info
80c92c4 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update RTPS recommendation
4af4c76 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update snippets with tcp_negotiation_timeout
f9c7827 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update env_var with tcp_negotiation_timeout
d053c25 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update xml with tcp_negotiation_timeout
3dc19f8 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Update use_case with tcp_negotiation_timeout
9c7ece9 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
JesusPoderoso
JesusPoderoso requested changes Mar 4, 2024
View reviewed changes
docs/fastdds/env_vars/env_vars.rst Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
code/XMLTesterExample.xml Outdated Show resolved Hide resolved
docs/fastdds/use_cases/tcp/tcp_large_data_with_options.rst Outdated Show resolved Hide resolved
docs/fastdds/use_cases/tcp/tcp_large_data_with_options.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/common.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/common.rst Outdated Show resolved Hide resolved
docs/fastdds/env_vars/env_vars.rst Show resolved Hide resolved
@cferreiragonz cferreiragonz force-pushed the feature/large_data_config_options branch from 2335201 to 750ae2c Compare March 5, 2024 07:09
@cferreiragonz
Copy link
Contributor Author

@richiprosima please test docs

@cferreiragonz
Refs #20493: Update docs with new XML schema
4b4b484 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the feature/large_data_config_options branch from 750ae2c to 4b4b484 Compare March 5, 2024 15:57
@cferreiragonz
Copy link
Contributor Author

@richiprosima please test docs

JesusPoderoso
JesusPoderoso requested changes Mar 5, 2024
View reviewed changes
docs/fastdds/xml_configuration/common.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/common.rst Outdated Show resolved Hide resolved
@cferreiragonz
Refs #20493: Apply suggestions
cfc9587 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Refs #20493: Apply suggestions
0e3f681 
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
Copy link
Contributor Author

@richiprosima please test docs

JesusPoderoso
JesusPoderoso approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added ci-pending implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS ready-to-merge and removed ci-pending labels Mar 6, 2024
@EduPonz EduPonz removed the implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS label Mar 7, 2024
@EduPonz EduPonz merged commit 48d5770 into master Mar 7, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/large_data_config_options branch March 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cferreiragonz @JesusPoderoso @EduPonz