[20503] Clarify history depth vs max_samples_per_instance inconsistency #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
@richiprosima please test docs |
JesusPoderoso
requested changes
Feb 22, 2024
EduPonz
force-pushed
the
hotfix/default-unlimited-resources
branch
from
912b895
to
6091ef4
Compare
EduPonz
changed the title
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
force-pushed
the
hotfix/default-unlimited-resources
branch
from
6091ef4
to
a66f8f6
Compare
|
@richiprosima please test this |
|
@Mergifyio backport 2.10.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit f5ab6a9)
JesusPoderoso
pushed a commit
that referenced
this pull request
Feb 22, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Feb 22, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
elianalf
pushed a commit
that referenced
this pull request
Mar 13, 2024
) (#674) * Improve History QoS documentation and compatibility rules (#664) * Refs #20401: Improve History documentation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Update example to out last standard tabs format Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Update all file examples Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Add NIT to explanation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Fix doc tab Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply spaces rev suggestion Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply documentation rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply documentation update based on internal discussion Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Remove old explanation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Improve documentation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply NIT Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 157375d) * Clarify depth vs max_samples_per_instance inconsistency (#679) Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 14, 2024
Mario-DL
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Improve History QoS documentation and compatibility rules (#664) * Refs #20401: Improve History documentation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Update example to out last standard tabs format Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Update all file examples Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Add NIT to explanation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Fix doc tab Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply spaces rev suggestion Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply documentation rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply documentation update based on internal discussion Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Remove old explanation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Improve documentation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20401: Apply NIT Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit 157375d) # Conflicts: # docs/fastdds/dds_layer/core/policy/standardQosPolicies.rst * Refs #20401: Fix conlficts Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Clarify depth vs max_samples_per_instance inconsistency (#679) Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for:
@Mergifyio backport 2.12.x 2.10.x 2.6.x