Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique network flows use-case [10552] #235

Merged
merged 11 commits into from
Mar 1, 2021
Merged

Unique network flows use-case [10552] #235

merged 11 commits into from
Mar 1, 2021

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Feb 24, 2021 •
edited
Loading

Adding documentation on the Unique Network flows use case.

Related to eProsima/Fast-DDS#1772

@MiguelCompany MiguelCompany changed the title Unique network flows Unique network flows [10552] Feb 24, 2021
@MiguelCompany MiguelCompany changed the title Unique network flows [10552] Unique network flows use-case [10552] Feb 24, 2021
@MiguelCompany MiguelCompany mentioned this pull request Feb 24, 2021
Merged
@richiprosima
Copy link
Contributor

Build status: Build Status

EduPonz
EduPonz suggested changes Feb 24, 2021
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, all the description is very readable and understandable. However, I'd appreciate some code snippets using the feature. Not only will it help readers, but the code will also be verified. This way, the use-case would be more in accordance with the rest of them,

@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 5dccc4a to 5d34a34 Compare February 25, 2021 06:46
@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 5387072 to 27cb049 Compare February 26, 2021 09:39
@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 27cb049 to 700c4bb Compare February 26, 2021 11:54
@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 700c4bb to 47c62d8 Compare February 26, 2021 12:06
@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany
Refs 10552. Add new page.
3dde1f5 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Initial structure and background.
a875cd4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Completed subsections.
409e467 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Added references to getter APIs.
9968051 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Renamed file and dir.
bc3103f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Adressed review comments.
9ff58a0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10522. Added example.
d834fc1 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 47c62d8 to d834fc1 Compare February 26, 2021 12:19
@richiprosima
Copy link
Contributor

Build status: Build Status

EduPonz
EduPonz previously approved these changes Feb 26, 2021
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI 🚀

@MiguelCompany
Refs 10522. Fixed indentation.
02b50f2 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany
Refs 10522. Fixed namespaces.
3a6a045 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/unique_network_flows branch from 507ef57 to 3a6a045 Compare March 1, 2021 08:08
@MiguelCompany
Refs 10522. Fixed operator.
70a65be 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima
Copy link
Contributor

Build status: Build Status

@richiprosima
Copy link
Contributor

Build status: Build Status

@MiguelCompany
Refs 10522. Fixed typo.
19d74bc 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima
Copy link
Contributor

Build status: Build Status

EduPonz
EduPonz approved these changes Mar 1, 2021
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 8b2548f into master Mar 1, 2021
@EduPonz EduPonz deleted the feature/unique_network_flows branch March 1, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiprosima @EduPonz