Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22012] Update migration guide removing things not related to application developer (backport #1003) #1014

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 16, 2025

Description

Modified the migration guide from Fast 2 to Fast 3. Eliminated some lines that referred to private files or internal tasks, and clarified a few points. Gave some change instructions a more clear "from ... to ..." format. Almost completely deleted step 9 as for the users the examples' fate should matter little.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #1003 done by [Mergify](https://mergify.com).

…eloper (#1003)

* Refs #22012: Updated Step 4 format

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Modified and expanded Step 1

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Updated Step 4

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Clarified the relocation of fixed_size_string.hpp

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Added TODO comments to start discussion

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Corrected the table in step 4

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Shortened Step 9 significantly

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: corrected typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Removed redundant line in step 6

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Solved failing CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Refs #22012: Solved failing CI

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Update docs/notes/migration_guide.rst

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
Signed-off-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
(cherry picked from commit 7874384)
@MiguelCompany MiguelCompany merged commit 7256c68 into 3.1.x Jan 17, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-1003 branch January 17, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants