Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21286] Remove CodeQL cron and other branch triggers #226

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JesusPoderoso
Copy link
Contributor

Description

Even though 2.2.x is a master mirror, it should not contain other branches triggers for CI, neither cron expressions (non-default branch).
This PR removes them.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jul 15, 2024
@JesusPoderoso JesusPoderoso added this to the v2.2.3 milestone Jul 15, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 15, 2024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides que conflicts I don't see why we'd run this only for 2.2.x and not master. IMO what we should do is:

  1. Run on PRs review request independently of the branches (same as CI). For this we'd need a partial backport of this in all supported branches.
  2. Run the analysis nightly on all the supported branches (which I think is possible without reusable workflows on any kind)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 21, 2024 17:01
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:21
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:24
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:31
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:35
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:42
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:45
signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 22, 2024 06:46
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@rsanchez15 rsanchez15 modified the milestones: v2.2.3, v2.2.4 Jul 26, 2024
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz July 26, 2024 11:49
@rsanchez15 rsanchez15 modified the milestones: v2.2.4, v2.2.5 Sep 6, 2024
@rsanchez15 rsanchez15 modified the milestones: v2.2.5, v2.2.6 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants