Make DiscoveryServer servers' guid prefix optional #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanlofer-eprosima
had a problem deploying
to
codecov
GitHub Actions
Failure
LuciaEchevarria99
force-pushed
the
integration/bump-3.0.0
branch
from
4d5e24d
to
2eb0bf5
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/optional-guidprefix
branch
from
973b2e6
to
eff1aab
Compare
juanlofer-eprosima
had a problem deploying
to
codecov
GitHub Actions
Failure
LuciaEchevarria99
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Change the CONFIGURATION DESCRIPTION in all the examples files to:
# 0: Use YAML configuration version v5.0
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
had a problem deploying
to
codecov
GitHub Actions
Failure
juanlofer-eprosima
merged commit ff7ff53
into
integration/bump-3.0.0
6 of 20 checks passed
LuciaEchevarria99
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Remove non-mandatory guid-prefix from discovery server blackbox tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Raise YAML reader version Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Remove non-required guid-prefix from DiscoveryServer Docker tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update documentation: version section Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update documentation and examples: guid-less discovery server Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update missing v4 -> v5 Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
added a commit
that referenced
this pull request
Sep 12, 2024
* Update repository for Fast DDS 3.0.0 compatibility Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Fix tests compilation Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Change DataWriter::write return value from bool to ReturnCode_t and fix tests Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Update compose tests Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Fix Docker tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Change utils::ReturnCode format and update tests Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Refactor participants destructors to use delete_contained_entities() Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Make DiscoveryServer servers' guid prefix optional (#467) * Remove non-mandatory guid-prefix from discovery server blackbox tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Raise YAML reader version Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Remove non-required guid-prefix from DiscoveryServer Docker tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update documentation: version section Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update documentation and examples: guid-less discovery server Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update missing v4 -> v5 Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Update stress testing tests after rebase Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Remove incorrect guid prefix tests for DiscoveryServerParticipant configuration Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Fix security tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Co-authored-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Co-authored-by: Irene Bandera <irenebandera@eprosima.com> Co-authored-by: juanlofer-eprosima <88179026+juanlofer-eprosima@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.