Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GTest version in windows CI #248

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fix GTest version in windows CI #248

merged 1 commit into from
Jul 15, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jul 13, 2022

Signed-off-by: jparisu javierparis@eprosima.com

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov July 13, 2022 12:38 Inactive
@jparisu jparisu temporarily deployed to codecov July 13, 2022 12:38 Inactive
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #248 (91780aa) into main (d1b6cbd) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   59.46%   59.28%   -0.19%     
==========================================
  Files          91       91              
  Lines        3200     3200              
  Branches     1188     1188              
==========================================
- Hits         1903     1897       -6     
- Misses        572      574       +2     
- Partials      725      729       +4     
Impacted Files Coverage Δ
ddsrouter_core/src/cpp/communication/Track.cpp 62.16% <0.00%> (-6.76%) ⬇️
...ntations/rtps/impl/CommonRTPSRouterParticipant.ipp 56.62% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b6cbd...91780aa. Read the comment docs.

@jparisu jparisu changed the title Fox GTest version in windows CI Fix GTest version in windows CI Jul 13, 2022
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu jparisu merged commit 99ea607 into main Jul 15, 2022
@jparisu jparisu deleted the hotfix/windows-gtest branch July 15, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants