Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added new icons and removed serveral icons #2528

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 16, 2025

Fixes #2516 and #2517

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added new icons and removed deprecated icons
  • Bonus change: fixed icons route by moving icons.json into its own file from +meta.json

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 2503d37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga requested a review from WinkeeFace January 16, 2025 20:13
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

@agliga agliga merged commit 4265bed into 19.0.0 Jan 17, 2025
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
This was referenced Jan 29, 2025
@agliga agliga deleted the new-icons branch January 31, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants