Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(floating-label): updated unselected color of label #2506

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat(floating-label): updated unselected color of label #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-falcons-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

feat(floating-label): updated unselected color of label
4 changes: 2 additions & 2 deletions dist/floating-label/floating-label.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ div.floating-label {

label.floating-label__label {
background-color: initial;
color: var(--floating-label-color, var(--color-foreground-primary));
color: var(--floating-label-color, var(--color-foreground-secondary));
display: inline-block;
left: 16px;
overflow: hidden;
Expand All @@ -38,7 +38,7 @@ label.floating-label__label {
}

label.floating-label__label--focus {
color: var(--color-background-inverse);
color: var(--floating-label-focus-color, var(--color-foreground-primary));
}

.floating-label--opaque label.floating-label__label--focus {
Expand Down
4 changes: 2 additions & 2 deletions src/sass/floating-label/floating-label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ div.floating-label {
}

label.floating-label__label {
@include color-token(floating-label-color, color-foreground-primary);
@include color-token(floating-label-color, color-foreground-secondary);

background-color: transparent;
display: inline-block;
Expand Down Expand Up @@ -43,7 +43,7 @@ label.floating-label__label {
}

label.floating-label__label--focus {
color: var(--color-background-inverse);
@include color-token(floating-label-focus-color, color-foreground-primary);
}

.floating-label--opaque label.floating-label__label--focus {
Expand Down