Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-button): refactored and fixed focus #2448

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Sep 17, 2024

Fixes #2295

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

I removed focus overrides in transparent icon button, itemized where icon buttons were being used, and verified fixes to styling issues when used in other modules. That fixed issues in:

  • Calendar
  • Date Textbox
  • Pagination
  • Textbox

I also manually removed focus overrides and added styling in Toast Dialog to bring it to parity, create consistency.

Screenshots

Before and After

transparent-button-fix-calendar-before
transparent-button-fix-calendar-after

Screenshot 2024-09-16 at 1 42 35 PM
Screenshot 2024-09-16 at 1 42 41 PM

Screenshot 2024-09-16 at 1 49 51 PM
Screenshot 2024-09-16 at 1 50 09 PM

Screenshot 2024-09-16 at 1 51 26 PM
Screenshot 2024-09-16 at 1 51 36 PM

Screenshot 2024-09-17 at 6 58 05 AM
Screenshot 2024-09-17 at 6 58 12 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: d2256fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtBlue ArtBlue merged commit 88c1091 into 18.3.0 Sep 20, 2024
@ArtBlue ArtBlue deleted the 2295-icon-button-refactor branch September 20, 2024 15:24
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants