Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): added sorting, cell types, actions, and inputs #2443

Closed
wants to merge 6 commits into from

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Sep 12, 2024

Fixes #1900

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

This PR is Iteration 2 of the Table module. It includes

  1. Sorting
  2. Cell Types
  3. Actions
  4. Inputs

Notes

The BEM structure was adjusted to better align with the markup structure.

Screenshots

image

image

image

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Sep 12, 2024
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 337c342

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtBlue ArtBlue closed this Sep 13, 2024
@ArtBlue
Copy link
Contributor Author

ArtBlue commented Sep 13, 2024

Closed this PR in lieu of #2444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants