Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(details): updated styling #2403

Merged
merged 4 commits into from
Jul 30, 2024
Merged

feat(details): updated styling #2403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05a3936
fix(details): updated spec
agliga Jul 29, 2024
d9dc7d8
chore: removed with:100 from details
agliga Jul 30, 2024
8c8b1b4
fix(details): added state layer
agliga Jul 30, 2024
d12df97
chore: removed centered example
agliga Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-chicken-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

details: updated design
20 changes: 14 additions & 6 deletions dist/details/details.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
summary.details__summary {
align-items: center;
border-radius: var(--expand-btn-border-radius, var(--border-radius-50));
box-sizing: border-box;
color: var(
--details-summary-foreground-color,
var(--color-foreground-accent)
var(--color-foreground-primary)
);
display: inline-block;
display: inline-flex;
font-size: var(--font-size-default);
font-weight: var(--font-weight-bold);
list-style-position: inside;
list-style-type: none;
padding: 12px 8px;
width: 100%;
}
summary.details__summary:before {
content: none;
Expand All @@ -19,11 +21,17 @@ summary.details__summary::-webkit-details-marker {
}
summary.details__summary:focus,
summary.details__summary:hover {
color: var(--color-state-accent-hover);
background-color: var(--color-state-secondary-hover);
outline: 1;
}
summary.details__summary:active {
background-color: var(--color-state-secondary-active);
outline: 1;
}

summary.details__summary--center {
text-align: center;
justify-content: center;
width: 100%;
}

summary.details__summary--small {
Expand All @@ -36,7 +44,7 @@ span.details__icon {
margin-inline-start: 8px;
}
span.details__icon[hidden] {
display: inline-block;
display: inline-flex;
}

details.details[open] span.details__icon {
Expand Down
65 changes: 16 additions & 49 deletions docs/_includes/details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ <h3>Default Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
{% include symbol.html name="chevron-down-12" %}
<svg class="icon icon--16" aria-hidden="true">
{% include symbol.html name="chevron-down-16" %}
</svg>
</span>
</summary>
Expand All @@ -27,8 +27,8 @@ <h3>Default Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -45,8 +45,8 @@ <h3>Opened Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
{% include symbol.html name="chevron-down-12" %}
<svg class="icon icon--16" aria-hidden="true">
{% include symbol.html name="chevron-down-16" %}
</svg>
</span>
</summary>
Expand All @@ -60,41 +60,8 @@ <h3>Opened Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
</svg>
</span>
</summary>
<p>Sample content</p>
</details>
{% endhighlight %}

<h3>Centered Details</h3>
<p>Apply the <span class="highlight">details__summary--center</span> class to center the summary.</p>

<div class="demo">
<div class="demo__inner">
<details class="details">
<summary class="details__summary details__summary--center">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
{% include symbol.html name="chevron-down-12" %}
</svg>
</span>
</summary>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</details>
</div>
</div>

{% highlight html %}
<details class="details">
<summary class="details__summary details__summary--center">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -110,8 +77,8 @@ <h3>Small Details</h3>
<summary class="details__summary details__summary--small">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
{% include symbol.html name="chevron-down-12" %}
<svg class="icon icon--16" aria-hidden="true">
{% include symbol.html name="chevron-down-16" %}
</svg>
</span>
</summary>
Expand All @@ -125,8 +92,8 @@ <h3>Small Details</h3>
<summary class="details__summary details__summary--small">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -142,8 +109,8 @@ <h3>RTL Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
{% include symbol.html name="chevron-down-12" %}
<svg class="icon icon--16" aria-hidden="true">
{% include symbol.html name="chevron-down-16" %}
</svg>
</span>
</summary>
Expand All @@ -156,8 +123,8 @@ <h3>RTL Details</h3>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand Down
29 changes: 19 additions & 10 deletions src/sass/details/details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,20 @@
@import "../mixins/private/token-mixins";

summary.details__summary {
align-items: center;
box-sizing: border-box;
@include border-radius-token(expand-btn-border-radius, border-radius-50);
@include color-token(
details-summary-foreground-color,
color-foreground-accent
color-foreground-primary
);

display: inline-block;
align-items: center;
box-sizing: border-box;
display: inline-flex;
font-size: var(--font-size-default);
font-weight: var(--font-weight-bold);
list-style-position: inside;
list-style-type: none; /* Remove details marker for non-webkit */
padding: 12px 8px;
width: 100%;

&::before {
content: none;
Expand All @@ -24,14 +26,21 @@ summary.details__summary {
display: none;
}

&:hover,
&:focus {
color: var(--color-state-accent-hover);
&:focus,
&:hover {
background-color: var(--color-state-secondary-hover);
outline: 1;
}

&:active {
background-color: var(--color-state-secondary-active);
outline: 1;
}
}

summary.details__summary--center {
text-align: center;
justify-content: center;
width: 100%;
}

summary.details__summary--small {
Expand All @@ -45,7 +54,7 @@ span.details__icon {

/* progressive enhancement - override hidden SVG */
span.details__icon[hidden] {
display: inline-block;
display: inline-flex;
}

details.details[open] {
Expand Down
12 changes: 6 additions & 6 deletions src/sass/details/stories/cascade.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export const RTL = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -22,8 +22,8 @@ export const colour = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -38,8 +38,8 @@ export const fontSize = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand Down
46 changes: 38 additions & 8 deletions src/sass/details/stories/details.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ export const closed = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -19,8 +19,8 @@ export const open = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -33,8 +33,8 @@ export const textSpacing = () => `
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -47,8 +47,8 @@ export const centered = () => `
<summary class="details__summary details__summary--center">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
Expand All @@ -59,6 +59,36 @@ export const centered = () => `
export const small = () => `
<details class="details" open>
<summary class="details__summary details__summary--small">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--16" aria-hidden="true">
<use href="#icon-chevron-down-16"></use>
</svg>
</span>
</summary>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</details>
`;

// Deprecated stories
export const closed12pxIcon = () => `
<details class="details">
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
<use href="#icon-chevron-down-12"></use>
</svg>
</span>
</summary>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</details>
`;

// Deprecated stories
export const open12pxIcon = () => `
<details class="details" open>
<summary class="details__summary">
<span class="details__label">Details</span>
<span class="details__icon" hidden>
<svg class="icon icon--12" aria-hidden="true">
Expand Down
Loading