Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split up :not for less parser #2377

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

LuLaValva
Copy link
Member

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Some older css parsers don't understand :not with commas

Notes

  • Stylelint encourages commas instead of multiple :not, so I needed to disable that rule

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@LuLaValva LuLaValva requested review from ArtBlue and agliga July 10, 2024 20:58
@LuLaValva LuLaValva self-assigned this Jul 10, 2024
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 0fbb683

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor

agliga commented Jul 10, 2024

Lgtm
Just wondering why docs file was changed. Those should be no longer checked in

ArtBlue
ArtBlue previously approved these changes Jul 10, 2024
@LuLaValva
Copy link
Member Author

Just wondering why docs file was changed. Those should be no longer checked in

I'm not sure why they changed either, this was modified when I ran a build. I reverted the change, seems out of scope for this PR.

@LuLaValva LuLaValva merged commit 83fc78d into master Jul 10, 2024
1 check passed
@LuLaValva LuLaValva deleted the simplify-textbox-syntax branch July 10, 2024 22:34
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants