Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOM anf metrics fixes #647

Merged
merged 3 commits into from
Feb 12, 2025
Merged

OOM anf metrics fixes #647

merged 3 commits into from
Feb 12, 2025

Conversation

raakella1
Copy link
Contributor

@raakella1 raakella1 commented Feb 12, 2025 •
edited
Loading

This PR has 2 fixes

  • set the wb req intrusive ptr to null in the completion callback to allow it to be destroyed
  • put the unmap counter in the NDEBUG preprocessor scope to disable it for non debug builds.

szmyd
szmyd approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szmyd szmyd merged commit cfc9fae into eBay:stable/v3.8.x Feb 12, 2025
12 of 16 checks passed
@raakella1 raakella1 deleted the unmap_ndebug branch February 12, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmyd szmyd szmyd approved these changes

@shosseinimotlagh shosseinimotlagh shosseinimotlagh approved these changes

@yamingk yamingk Awaiting requested review from yamingk

@sanebay sanebay Awaiting requested review from sanebay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raakella1 @szmyd @shosseinimotlagh