Added E6data support in the dialects.py #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adithyakanamarlapudi <kanamarlapudi@e6x.io>
shreyas2201
requested changes
Oct 10, 2024
| @@ -18,7 +18,16 @@ | |||
| SQLite, | |||
| Trino, | |||
| ) | |||
| from sqlglot.dialects.dialect import rename_func | |||
| from sqlglot.dialects.dialect import ( | |||
…int at appropriate places.
|
@shreyas2201 Added generator import and some more changes and pushed it in the commit |
… binary on left. And also inheriting from SqlGlotCompiler rather than MYSQLcompiler.
shreyas2201
requested changes
Oct 17, 2024
ibis/backends/e6data/compiler.py
Outdated
| __slots__ = () | ||
|
|
||
| dialect = E6data | ||
| type_mapper = E6DataType | ||
|
|
||
| def visit_Equals(self, op, *, left, right): | ||
| return sge.EQ(this=left, expression=right) |
There was a problem hiding this comment.
You are directly using SQLGlotCompiler
you dont need this now
|
removed that part @shreyas2201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.