Simple heat consumer implementation #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hermal properties of a consumer (mass flow, heat extraction, temperature difference and return temperature) Note: the model currently only works with set mass flow and heat extraction, as the other modes require a more dedicated simulation wrt. the update of fluid properties between heat transfer iterations and a feedback of heat transfer results to hydraulics
# Conflicts: # src/pandapipes/component_models/heat_consumer_component.py # src/pandapipes/test/api/test_components/test_heat_consumer.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #599 +/- ##
===========================================
- Coverage 90.49% 86.72% -3.78%
===========================================
Files 139 89 -50
Lines 10549 6168 -4381
===========================================
- Hits 9546 5349 -4197
+ Misses 1003 819 -184 ☔ View full report in Codecov by Sentry. |
EPrade
reviewed
Mar 18, 2024
EPrade
reviewed
Mar 18, 2024
EPrade
previously approved these changes
Mar 25, 2024
- shifted some branch initialization to branch_wzerolength_models.py (also for heat_exchanger_component.py) - switched order of arguments in component (qext and mdot)
SimonRubenDrauz
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first implementation includes a model that combines the two components heat_exchanger and flow_control. A user can set the desired extracted heat flux and the mass flow through this consumer that can thereby directly connect flow and return system of a district heating network.