Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor & optimize ENV accessors #7

Merged
merged 6 commits into from
Feb 7, 2016
Merged

[WIP] Refactor & optimize ENV accessors #7

merged 6 commits into from
Feb 7, 2016

Commits on Feb 1, 2016

  1. Pass &callback to Loader constructor, not to #load method.

    @marshall-lee
    marshall-lee committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    9bfc611 View commit details
    Browse the repository at this point in the history

  2. Pass &callback to Dumper constructor, not to #dump method.

    @marshall-lee
    marshall-lee committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    387f886 View commit details
    Browse the repository at this point in the history

  3. Lazily initialize loader and dumper.

    @marshall-lee
    marshall-lee committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    a26b127 View commit details
    Browse the repository at this point in the history

  4. Refactor main specs. 

    Creepy mocks are removed.
Common behavior is extracted to shared examples.
    @marshall-lee
    marshall-lee committed Feb 1, 2016
    Configuration menu
    Copy the full SHA
    c568e8e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2016

  1. Loader/Dumper strategy factory.

    @marshall-lee
    marshall-lee committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    60afe58 View commit details
    Browse the repository at this point in the history

  2. Make MockEnv#[]= more compatible with ENV.

    @marshall-lee
    marshall-lee committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    ecdf57a View commit details
    Browse the repository at this point in the history