Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text_truncate patch for discussion #5278 #5306

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rica-carv
Copy link
Contributor

Motivation and Context

Possible fix for discussion #5278

Description

Function changed to truncate also on word, not only in string

How Has This Been Tested?

Tested with E107 v 2.3.3

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Aditional check for external linked avatars.
Without the code, external linked avatars not available are shown without the default avatar
Changed file_exists to fopen, to check if remote file exists
Aditional change to make default avatar image render
@rica-carv rica-carv changed the title Text_truncatepatch for discussion #5278 Text_truncate patch for discussion #5278 Aug 3, 2024
Copy link

codeclimate bot commented Aug 3, 2024

Code Climate has analyzed commit 9c156d4 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1

The test coverage on the diff in this pull request is 66.6% (80% is the threshold).

This pull request will bring the total coverage in the repository to 39.2% (0.7% change).

View more on Code Climate.

@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 22, 2024

@rica-carv your commits are so complicated. I am trying to find out what did you do to fix this problem, but it is not possible for me.
I don't think they merge this...
As I know, each PR should be in a different branch and only with changes related to the issue - what has avatar's changes with this topic?

How I can test this to confirm it is ok if I am not able to see your change? And I think you can override somebody else changes with PR like this.
You are doing awesome work, I appreciate it, I am just trying to help too. I am surprised that nobody else told you this. Or I am mistaken and it is not problem?

@rica-carv
Copy link
Contributor Author

rica-carv commented Aug 23, 2024

@Jimmi08 You can see i only changed one file, i don't understand why the other comits are there, i can't delete them , but they simply do nothing.

I was changing the avatar on my base branch, and then i remember i must do it all in separated branches, and i did so, but i had to reversed back all my changes in the base branch. The base branch is now equal to the base branch of e107 here, so i don't know how to get rid of all those dummy comits.

I'm working only via github site, because i do all the tests in a portable environment, so i can't figure out what i'm doing wrong. I would be happy if i could erase all those dummy comits of my base branch, but they are stuck there....

image

See, i can't figure out what to do, it doesn't has any changes to update... Real weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants