Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4830: Sensible no delete log in admin_log_ui::maintenanceProcess() #4831

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Jul 28, 2022

Fixes: #4830

Motivation and Context

$sql->mySQLresult can't magically be turned into a string, so use the actual interface, e_db::getLastErrorText().

Description

The SQL last error text will be printed, if any, when there are no system logs to delete in /e107_admin/admin_log.php?mode=main&action=maintenance.

How Has This Been Tested?

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2022

Code Climate has analyzed commit 62b5c84 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.3% (-0.4% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Sep 29, 2022

Thanks 👍

@CaMer0n CaMer0n merged commit 2de2336 into e107inc:master Sep 29, 2022
@Deltik Deltik deleted the fix/4830 branch September 30, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error when deleting logs
2 participants