Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4708 load bbcode buttons only if HTML is allowed for user #4732

Conversation

Jimmi08
Copy link
Contributor

@Jimmi08 Jimmi08 commented Mar 31, 2022

CLOSES #4708

Motivation and Context

#4708

Description

see issue

How Has This Been Tested?

Tested scenarios:

  • site wysiwyg on, html access - result tinymce
  • site wysiwyg on, no html access - result bbcodes
  • site wysiwyg off, forum wysiwyg on, no html access - result bbcodes
  • site wysiwyg off, forum wysiwyg on, html access - result tinymce
    It worked like this before too, but bbcodes were always rendered (not visible with tinymce)

CLOSES #4665

Tested scenarios:

- site wysiwyg on, html access  -  result tinymce
- site wysiwyg on,  no html access  - result bbcodes
- site wysiwyg off,  forum wysiwyg on,  no html access  - result bbcodes
- site wysiwyg off,  forum wysiwyg on,  html access  - result tinymce

It worked like this before too, but bbcodes were always rendered (not visible with tinymce)
@CaMer0n CaMer0n merged commit 91f9020 into e107inc:master Apr 1, 2022
@Jimmi08 Jimmi08 deleted the load-bbcode-buttons-only-if-HTML-is-allowed-for-user branch April 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load bbcode buttons only if tinymce is used
2 participants